Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update II mobile integration sequence diagrams to use mermaid #3930

Merged
merged 5 commits into from
Feb 10, 2025

Conversation

roelstorms
Copy link
Contributor

Update II mobile integration sequence diagrams to use mermaid

Thank you for your contribution to the IC Developer Portal. This repo contains the content for https://internetcomputer.org and the ICP Developer Documentation, https://internetcomputer.org/docs/.

If you are submitting a Pull Request for adding or changing content on the ICP Developer Documentation, please make sure that your contribution meets the following requirements:

Update II mobile integration sequence diagrams to use mermaid
@github-actions github-actions bot added the documentation Changes to Developer Docs label Jan 7, 2025
@roelstorms
Copy link
Contributor Author

If anyone (@robin-kunzler @venkkatesh-sekar) has a nicer way to add a caption or title to the sequence diagram, please go ahead.

The notes on the sequence diagrams can only be changed color globally so unless we really oppose the fact they are not as visible anymore I'd avoid doing that.

@roelstorms roelstorms marked this pull request as ready for review January 7, 2025 15:58
@roelstorms roelstorms requested a review from a team as a code owner January 7, 2025 15:58
Copy link
Member

@venkkatesh-sekar venkkatesh-sekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approved modulo a single comment.

@roelstorms roelstorms enabled auto-merge (squash) February 10, 2025 15:51
@roelstorms roelstorms merged commit f6fbcd7 into master Feb 10, 2025
7 checks passed
@roelstorms roelstorms deleted the roelstorms-II-mobile-sequence-diagram branch February 10, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes to Developer Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants